leinir added a comment.

  It would make fine sense to merge this in already (i'll merge it into the 
branch), as this is, of course, fairly important to get in, and there are 
things in my branch which may need some further discussions before a final 
merge (though i hope it's more a case of "woop, do the thing!" ;) ). So... 
thumbs up from here, all looks fine to me :)

INLINE COMMENTS

> mart wrote in provider_p.h:63
> EntryId?

hmm... had a quick think there, and there's a small semantic difference: A 
filter on EntryID would potentially (in my head at least) filter on whatever 
you handed it, so filtering by EntryID "123" would find both "123" and "1234", 
whereas something filtering by ExactEntryID "123" would find only "123"... but 
it /is/ a very small difference...

REVISION DETAIL
  https://phabricator.kde.org/D3234

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, mart, leinir

Reply via email to