----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129314/#review100567 -----------------------------------------------------------
Ship it! I can't compile it, but the code looks fine, apol's comments have been addressed, I trust Burkhard's testing (maybe we should add an automated test for this) and we have a tag tomorrow. So let's go for it. - Luigi Toscano On Nov. 4, 2016, 9:18 a.m., Ralf Habacker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129314/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 9:18 a.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Bugs: 371987 > https://bugs.kde.org/show_bug.cgi?id=371987 > > > Repository: kdoctools > > > Description > ------- > > Fix 'checkXML5 generates html files in workdir for valid docbooks'. > > BUG:371987 > > > Diffs > ----- > > src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 > > Diff: https://git.reviewboard.kde.org/r/129314/diff/ > > > Testing > ------- > > tested on opensuse 13.2 > > > Thanks, > > Ralf Habacker > >