----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129405/ -----------------------------------------------------------
(Updated Nov. 15, 2016, 9:53 a.m.) Review request for KDE Frameworks, KDE Usability, Christoph Feck, and David Edmundson. Changes ------- Also add unit test. Repository: kwidgetsaddons Description ------- Currently it's not possible to hide widgets in a KCollapsibleGroupBox, because the groupbox hides all chidren on collapse event and shows them on expand event. The rationale was explained in this comment: "when collapsed hide contents to save resources and more importantly get it out the focus chain" The focus chain problem can be solved by overriding/restoring the focus policy of children widgets, without changing their visibility. Diffs (updated) ----- autotests/kcollapsiblegroupbox_test.h b7f538217f480ea48bc28f098c7968fe21dda676 autotests/kcollapsiblegroupbox_test.cpp 4c458c4f700e498c178a637c29d6cc78ab8c267c src/kcollapsiblegroupbox.cpp 273110e995cb25f28a815cb28125c4678ca2ab28 tests/kcollapsiblegroupboxtest.cpp 5a2900e63e42fa81f909c7d1fff0d07033edb025 Diff: https://git.reviewboard.kde.org/r/129405/diff/ Testing ------- Test app has been expanded with an hidden checkbox * Make sure the new checkbox stays hidden after expanding the groupbox. * With both groups collapsed, make sure the tab-focus goes from the first group to the second one (skipping the 7 checkboxes in the first group). Thanks, Elvis Angelaccio
