----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review101225 -----------------------------------------------------------
Honestly i don't see anything wrong with the patch but i didn't see anything wrong with the old code either, i.e. i don't know much about this. But you say you've been using it and looks good and there doesn't seem to be anyone willing to give you a ship it. I'd say you just ship it yourself and then take full responsability in looking thoguh new bugs in case you break something and fix it immediately or revert the change. - Albert Astals Cid On Nov. 13, 2016, 5:17 a.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127216/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2016, 5:17 a.m.) > > > Review request for KDE Frameworks, Martin Gräßlin and Martin Klapetek. > > > Bugs: 356523 > https://bugs.kde.org/show_bug.cgi?id=356523 > > > Repository: knotifications > > > Description > ------- > > Store position of widget before hide it > > > Diffs > ----- > > src/kstatusnotifieritem.cpp 3eb39b2 > src/kstatusnotifieritemprivate_p.h 8fdfd4c > > Diff: https://git.reviewboard.kde.org/r/127216/diff/ > > > Testing > ------- > > Tested on pixel ratio = 1 with Amarok, Kmail, Akregator, Kalarm, Ktimer > Close with 'X' - restore in correct pos > Hide by click at icon in systray - restore correct pos > > > Thanks, > > Anthony Fieroni > >
