----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129607/ -----------------------------------------------------------
(Updated Dec. 7, 2016, 11:30 a.m.) Review request for KDE Frameworks, KDE Usability and Sebastian Kügler. Changes ------- Renamed tab to "Libraries", removed "Using" in tab text Repository: kxmlgui Description ------- Last year, a change in kaboutapplicationdialog (review 124133) moved the application version in a separate tab. However for applications, it is really annoying (several Kdenlive users complained and I fully agree) to not have this information clearly displayed as soon as the About dialog is displayed. I understand the interest of having a separate version tab displaying the various underlying libraries used, but I propose to display again the application version in the About dialog header (see screenshot). Diffs (updated) ----- src/kaboutapplicationdialog.cpp 156410e Diff: https://git.reviewboard.kde.org/r/129607/diff/ Testing ------- Reverts a recent change, tested and works. File Attachments ---------------- About dialog with version https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/c02f4767-2a74-4c25-8599-de410678867e__about.png Updated patch https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/ee13cb47-2162-4be7-8255-3dce7f470c2b__about2.png Thanks, Jean-Baptiste Mardelle