----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129658/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: kconfigwidgets Description ------- The static maps s_changedMaps() and s_propertyMap() still contain a bunch of old class names (even from kdelibs3 times!). This patch replaces most of the hardcoded class names with `QMetaObject::className()`, to ensure compile-time checks and that we don't use non-kf5 classes. We keep the hardcoded names only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, KIO). Diffs ----- src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa Diff: https://git.reviewboard.kde.org/r/129658/diff/ Testing ------- Builds, tests pass. Thanks, Elvis Angelaccio
