-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129660/
-----------------------------------------------------------
Review request for KDE Frameworks and Jeremy Whiting.
Repository: knewstuff
Description
-------
`QStrandardPaths::locate` returns `{}` when an absolute path is passed so we
can't use it to extract the file's baseName.
Also simplifies a bit the logic that was relying on a class attribute that was
only used in that function and we turned into a local variable. It was adding a
`':'` that doesn't make sense anymore and I dropped as well.
Diffs
-----
src/core/engine.h e69dee3
src/core/engine.cpp a5758f0
Diff: https://git.reviewboard.kde.org/r/129660/diff/
Testing
-------
Tests still pass, doesn't choke anymore on a full path (tested from Discover).
Thanks,
Aleix Pol Gonzalez