> On Dec. 14, 2016, 8:21 p.m., Martin Gräßlin wrote: > > If I see correctly we are losing a feature here: blur behind. > > Elvis Angelaccio wrote: > Right, I had to drop that because we cannot use KWindowSystem in tier 1. > Is there a way to achieve the same feature with Qt only? > > Martin Gräßlin wrote: > Well there are multiple solutions: > > * don't put it in this framework > * make this framework a tier 2 > * add a property and let Plasma's platform plugin do the blurring > > Elvis Angelaccio wrote: > > add a property and let Plasma's platform plugin do the blurring > > Can you expand on this? How would it work? Sounds like the best > solution...
sure, we have an example for it. KColorSchemeManager installs a property on the app, which is then read by the plasma-integration. In plasma-integration we have an event filter which monitors for all windows which get created and then install the X11/Wayland property. In your case it will be even easier. Just set a dynamic property on the QWindow (not the QWidget!) to hint a fullscreen blur. Then we can do the respective call in plasma-integration. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/#review101445 ----------------------------------------------------------- On Dec. 13, 2016, 4:45 p.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129648/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 4:45 p.m.) > > > Review request for KDE Frameworks, Ben Cooksley, Christoph Feck, and Martin > Gräßlin. > > > Repository: kwidgetsaddons > > > Description > ------- > > This new widget is based on the KToolTip code that is duplicated across > multiple products: at least Dolphin, systemsettings, kinfocenter, > ktp-contact-list. > > Rationale: with a single class in frameworks, it will be possible to apply > features/fixes only once. See for example the comments in > https://phabricator.kde.org/D3112 > > A new feature that the old code doesn't have is the delayed hide: this makes > it possible to actually use the widget shown in the tooltip. > > > Diffs > ----- > > autotests/CMakeLists.txt ffcce3a046ec98b07c4677578f6bc997de1ef16b > autotests/ktooltipwidgettest.h PRE-CREATION > autotests/ktooltipwidgettest.cpp PRE-CREATION > src/CMakeLists.txt de0a8d965f1541d5ffeec93d1aa06600b0b9c138 > src/ktooltipwidget.h PRE-CREATION > src/ktooltipwidget.cpp PRE-CREATION > tests/CMakeLists.txt fcb348b1ae9d4270468c3f9003c5ba5f3903db84 > tests/ktooltipwidget_test.h PRE-CREATION > tests/ktooltipwidget_test.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129648/diff/ > > > Testing > ------- > > Manual test works both in X11 and Wayland. Unit tests pass. > > Ported Dolphin locally to this new class, everything seems to work (and this > will fix bug [#352276](https://bugs.kde.org/show_bug.cgi?id=352276) and > [#371223](https://bugs.kde.org/show_bug.cgi?id=371223)). > > > Thanks, > > Elvis Angelaccio > >
