> On Dec. 16, 2016, 5:55 p.m., Aleix Pol Gonzalez wrote: > > Waiting for feedback from tsdgeos on the change in scripty. > > Albert Astals Cid wrote: > Looks good (make sure you commit to the correct location (i.e. i guess we > want this for stable and trunk kf5, not kdelibs 4 version of the scripts))
Can you please commit there? I don't have enough karma. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129654/#review101474 ----------------------------------------------------------- On Dec. 15, 2016, 5:05 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129654/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2016, 5:05 p.m.) > > > Review request for KDE Frameworks and Jeremy Whiting. > > > Repository: knewstuff > > > Description > ------- > > Discover has been changed to display all installed `knsrc` files in the > system instead of having a static list in the system. For that to happen I'd > like to include in the `knsrc` file a title that describes the contained > resources. > > This should be accompanied with the following change to scripty to enable > translations of the field: > ``` > Index: findfiles > =================================================================== > --- findfiles (revision 1477134) > +++ findfiles (working copy) > @@ -28,7 +28,7 @@ > continue > fi > echo "$dir" > - find "$dir" ( -path "*/test/*" -o -path "*/tests/*" -o -path > "*/autotest/*" -o -path "*/autotests/*" ) -prune -o ( ( -name *.directory -o > -name *.desktop -o -name *.desktop.cmake -o -name *.kimap -o -name *.themerc > -o -name *.kcsrc -o -name *.setdlg -o -name index.theme -o -name *.notifyrc > -o -name *.protocol -o -name *.profile -o -name *.actions ) -a ( -type f -o > -type l ) -print ) >> $filelist > + find "$dir" ( -path "*/test/*" -o -path "*/tests/*" -o -path > "*/autotest/*" -o -path "*/autotests/*" ) -prune -o ( ( -name *.directory -o > -name *.desktop -o -name *.knsrc -o -name *.desktop.cmake -o -name *.kimap -o > -name *.themerc -o -name *.kcsrc -o -name *.setdlg -o -name index.theme -o > -name *.notifyrc -o -name *.protocol -o -name *.profile -o -name *.actions ) > -a ( -type f -o -type l ) -print ) >> $filelist > extradesktopscripts=`find $dir -name ExtraDesktop.sh` > initialdir=`pwd` > for extradesktopscript in $extradesktopscripts; do > ``` > > > Diffs > ----- > > src/downloaddialog.cpp 5831211 > > Diff: https://git.reviewboard.kde.org/r/129654/diff/ > > > Testing > ------- > > The `Name` field is used when available, also adopted it in Discover. > > > Thanks, > > Aleix Pol Gonzalez > >