----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126291/ -----------------------------------------------------------
(Updated Dec. 27, 2016, 5 p.m.) Review request for KDE Software on Mac OS X and KDE Frameworks. Changes ------- bump refactored against v4.100.0-rc1-189-g824d4f2 for 5.30.0 Repository: kwindowsystem Description ------- KWindowSystem has been lacking a platform plugin for OS X. This RR presents a "backport" of the modified KDE4 KWindowSystem implementation that has been used in the MacPorts kdelibs4 port for the last 2 or 3 (or more) years. I have made some initial steps to remove deprecated Carbon API calls, but this is clearly a work in progress. Open questions include - is there any justification to run an event handler (or Cocoa observer) to keep track of running applications, possibly even listing all their open windows? - is there any use for the Qt event listener framework (cf. the NETEventFilter in the X11 plugin)? I haven't yet had time to try to figure out what this "could be good for", and am very open to suggestions in this departments. - one application for such an event filter would be a listener that catches the opening and closing of all windows by the running process, and keeps track of their `WId`s. A new method could then be added (to `KWindowInfo`?) to distinguish `WId`s created by the running application from "foreign" ones (useful also on Wayland and MS Windows). `KWindowSystem::setMainWindow` should become a front for payload provided by the plugins. I'll leave that to the regular/official maintainer(s) of this framework. This code could probably do with *lots* of comments; I'll try to add them as questions about this or that bit of code arise. Diffs (updated) ----- src/kwindowsystem.h a282ecd src/kwindowsystem.cpp fda1682 src/platforms/osx/CMakeLists.txt 4fc3347 src/platforms/osx/cocoa.json PRE-CREATION src/platforms/osx/kkeyserver.cpp 3ddb921 src/platforms/osx/kwindowinfo.cpp e8555bb src/platforms/osx/kwindowinfo.mm PRE-CREATION src/platforms/osx/kwindowinfo_mac_p.h c8f307e src/platforms/osx/kwindowinfo_p_cocoa.h PRE-CREATION src/platforms/osx/kwindowsystem.cpp 1758829 src/platforms/osx/kwindowsystem_mac_p.h PRE-CREATION src/platforms/osx/kwindowsystem_macobjc.mm PRE-CREATION src/platforms/osx/kwindowsystem_p_cocoa.h PRE-CREATION src/platforms/osx/plugin.h PRE-CREATION src/platforms/osx/plugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126291/diff/ Testing ------- On OS X 10.9.5 with Qt 5.5.1 and frameworks 5.16.0 . Thanks, René J.V. Bertin
