dfaure added a comment.
Can you add a unittest too? This class is fully unittested in krearrangecolumnsproxymodeltest.cpp, it's just that changing the source columns configuration "at runtime" wasn't supported. Just add one more test method, with spies for the signals you emit. Thanks! REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D3548 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: lepagevalleeemmanuel, #frameworks, dfaure Cc: kfunk, ltoscano
