----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129729/ -----------------------------------------------------------
Review request for KDE Software on Mac OS X and KDE Frameworks. Repository: kservice Description ------- I noticed that kbuildsyscoca.cpp may delete `QStandardPaths::writableLocation(QStandardPaths::ApplicationsLocation)`, according to the comments if that location is empty, but in practice no check is made whether that's the case. And that makes the tool very dangerous on Mac, where the native ApplicationsLocation is something very different. Diffs ----- src/sycoca/kbuildsycoca.cpp 5e63907 Diff: https://git.reviewboard.kde.org/r/129729/diff/ Testing ------- Works as intended (though I haven't tried to get it to fail, for some curious reason :)) Thanks, René J.V. Bertin
