----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129741/ -----------------------------------------------------------
Review request for KDE Frameworks, David Faure and Emmanuel Pescosta. Repository: kio Description ------- An ioslave protocol might support moving files but not "renaming" them (rename here means "the F2 shortcut in filemanagers"). trash:/ is a good example. The new `renaming` field defaults to `moving`, so that we don't have to add renaming=true to every protocol file out there. Diffs ----- src/core/kfileitemlistproperties.h 2b4a5b33166513493e6499e6479a04965a895b57 src/core/kfileitemlistproperties.cpp 5c6e6bba693f8b9bfc942ff39bee5d24f159fd7f src/core/kprotocolinfo.cpp 0290c63b37a45a22995238f9cfcc11b8334d339c src/core/kprotocolinfo_p.h 8d05bd194fdaa7b7e7552e0d1d22bf16b28ffbc1 src/core/kprotocolmanager.h 13b8c0756f8e355b1ec84cdf1c44086f41fa05c5 src/core/kprotocolmanager.cpp 9a0a96fe749a11c66a22bb3eff62d0601e3b7b36 src/ioslaves/trash/tests/testtrash.cpp 67a6130e7c86af00e596dc439125c29eb74fc99f src/ioslaves/trash/trash.json d7dc03eb073c7bfdde3c7eebfbac144ad62964fe src/protocoltojson/main.cpp 0bf3c7062d076412c779f6cae25a98e1b2c61be4 Diff: https://git.reviewboard.kde.org/r/129741/diff/ Testing ------- Using the new `supportsRenaming()` api from Dolphin, F2 in Trash is now disabled. More context in https://git.reviewboard.kde.org/r/129714 Thanks, Elvis Angelaccio
