----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129723/#review101718 -----------------------------------------------------------
Ship it! This is going to be called multiple times in apps with parts and plugins, but I guess that's OK, the developer will fix the bug and the user will check the checkbox. - David Faure On Jan. 2, 2017, 10:34 a.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129723/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2017, 10:34 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kparts > > > Description > ------- > > What summary says > > > Diffs > ----- > > src/mainwindow.cpp b335598 > > Diff: https://git.reviewboard.kde.org/r/129723/diff/ > > > Testing > ------- > > > Thanks, > > Albert Astals Cid > >
