----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129733/#review101744 -----------------------------------------------------------
Ship it! Ship It! - René J.V. Bertin On Jan. 2, 2017, 9:57 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129733/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2017, 9:57 p.m.) > > > Review request for KDE Frameworks, Albert Astals Cid and René J.V. Bertin. > > > Repository: kservice > > > Description > ------- > > Symlinks to (desktop) files are still supported. > > > Diffs > ----- > > autotests/ksycocatest.cpp 4564ee6750a80a109492c197c83944e129dcabac > src/sycoca/ksycocautils_p.h f144a80ea6d845ed5eaff41689756b30f17d9391 > src/sycoca/vfolder_menu.cpp 5acbf8ac21a1a0170cee4aa96882bd97eb2a4f2a > > Diff: https://git.reviewboard.kde.org/r/129733/diff/ > > > Testing > ------- > > Added unittest (which failed before the fix, passes after the fix) > > > Thanks, > > David Faure > >