On 03/01/17 14:13, David Faure wrote: >> No objection. > > I do, however, have an objection to untested commits. > > Sven, your commits broke knewstuff and some other modules. > > CMake Error at /d/kde/inst/kde_frameworks/share/ECM/modules/ > ECMGeneratePriFile.cmake:137 (message): > Required variable PROJECT_VERSION_STRING not set before > ECM_GENERATE_PRI_FILE() call. Did you call ecm_setup_version? > Call Stack (most recent call first): > src/core/CMakeLists.txt:94 (ecm_generate_pri_file) > > Changing the min required cmake version also changes the default values for a > number of cmake policies, so you need to adjust the cmakelists.txt > accordingly.
I'm sorry. I completely forgot changing the minimum cmake version changes these defaults (and thus actually affects behaviour). I'll look into it right now.
signature.asc
Description: OpenPGP digital signature
