----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129795/#review101886 -----------------------------------------------------------
Ship it! Ship It! - Volker Krause On Jan. 8, 2017, 5:32 p.m., Dominik Haumann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129795/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2017, 5:32 p.m.) > > > Review request for Kate, KDE Frameworks, Christoph Cullmann, and Volker > Krause. > > > Repository: syntax-highlighting > > > Description > ------- > > Currently, the QDirIterator lists *all* files when searching for highlighting > files and theme files. > This for instance also includes backups (.xml~) and similar files, which is > obviously wrong. > > This patch fixes this by searching only for .xml files and .theme files. > > > Diffs > ----- > > src/lib/repository.cpp 13783f8 > > Diff: https://git.reviewboard.kde.org/r/129795/diff/ > > > Testing > ------- > > Compiles, unit tests still run. > > > Thanks, > > Dominik Haumann > >
