----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129776/#review102067 -----------------------------------------------------------
We could try to improve it: - make the size of the text depend on the used font metrics - actually use supported icon sizes (64?) - change the item view's elide mode to Left or Middle, instead of Right? - Christoph Feck On Jan. 4, 2017, 7:58 p.m., Māris Nartišs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129776/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2017, 7:58 p.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Bugs: 215384 > https://bugs.kde.org/show_bug.cgi?id=215384 > > > Repository: kiconthemes > > > Description > ------- > > Enabling word wrapping and leaving some space for icon text makes them more > useable. Be ware - this might not be the best solution, as I have no idea of > C++ (cargo cult programming sometimes works). > > > Diffs > ----- > > src/kicondialog.cpp 68650ed > > Diff: https://git.reviewboard.kde.org/r/129776/diff/ > > > Testing > ------- > > Looked fine on Gentoo ~AMD64 when tested as a part of > kde-frameworks/kiconthemes-5.29.0 > > > Thanks, > > Māris Nartišs > >
