> On Jan. 16, 2017, 8:53 a.m., Kevin Funk wrote: > > @Stephen: Let's re-introduce this patch? Laurent + me have applied > > `Q_DECL_OVERRIDE` everywhere. Do you want to double-check?
Sorry, I didn't get pinged by email about this, despite the mention from Albert below. Re-applying this sounds fine to me. Thanks for taking care of the porting! - Stephen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129724/#review102057 ----------------------------------------------------------- On Jan. 16, 2017, 9:12 a.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129724/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2017, 9:12 a.m.) > > > Review request for Build System, KDE Frameworks and Stephen Kelly. > > > Repository: extra-cmake-modules > > > Description > ------- > > Gives a nice warning about something that should be marked as override but > isn't > > > Diffs > ----- > > kde-modules/KDEFrameworkCompilerSettings.cmake 038ddc3 > > Diff: https://git.reviewboard.kde.org/r/129724/diff/ > > > Testing > ------- > > > Thanks, > > Albert Astals Cid > >
