apol added inline comments. INLINE COMMENTS
> dfaure wrote in kcrash.cpp:437 > You can't use QVector here. We're crashing, likely due to corrupted memory, > the whole point of this code is to NOT do any memory allocation. You should > revert to const char*[], or use something that always allocates on the stack > (e.g. QVarLengthArray, if preallocated to be big enough). Yes... that makes sense. But then possibly worse than that is the use of QMap. Will rethink the approach. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D4201 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, dfaure Cc: shumski, anthonyfieroni, graesslin
