shaheed added inline comments. INLINE COMMENTS
> skelly wrote in rules_engine.py:58 > I don't think this should be here. I disagree. Having this in the code suppresses the false positives which are caused by the "_" used by gettext. > skelly wrote in rules_engine.py:704 > I don't think the comments are valuable. I think they are perfectly reasonable. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D4509 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: shaheed, #build_system, #frameworks, skelly Cc: #frameworks, #build_system