----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129987/#review102732 -----------------------------------------------------------
src/gui/kstandardshortcut.cpp (line 203) <https://git.reviewboard.kde.org/r/129987/#comment68385> This search doesn't need to restart at i+1, it could restart at other (which is further along). (other + 1, minus 1 because of the removal == other) Alternatively this could use the STL erase+remove idiom. - David Faure On March 6, 2017, 12:20 a.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129987/ > ----------------------------------------------------------- > > (Updated March 6, 2017, 12:20 a.m.) > > > Review request for KDE Frameworks. > > > Bugs: 375555 > https://bugs.kde.org/show_bug.cgi?id=375555 > > > Repository: kconfig > > > Description > ------- > > For some reason some people have kdeglobals entries like > Close=Ctrl+W; Ctrl+Esc; Ctrl+W; Ctrl+Esc; > having the same shortcut more than once in the shortcut declaration is > clearly bogus so fix it > > > Diffs > ----- > > src/gui/kstandardshortcut.cpp 9e7b1cf > > Diff: https://git.reviewboard.kde.org/r/129987/diff/ > > > Testing > ------- > > Created broken kdeglobals file manually, don't get warnings anymore > > > Thanks, > > Albert Astals Cid > >