mart added a comment.
the discussion seems to me a bit unrelated with the review in itself. for me the patch is ok, +1 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D4972 To: davidedmundson, #plasma Cc: mart, hein, broulik, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
