mck182 added a comment.
Looks like this could work. The `KDE_FULL_SESSION` check is really old, I'm not sure if this has any implications. As David noted, the waiting thing should go to Plasma workspace, that's where it belongs. Also, it would be preferred if the implementation was properly split into main.cpp and your class .h and .cpp INLINE COMMENTS > main.cpp:39 > + Q_OBJECT > +private: > + constexpr static const int dbusTimeoutSec = 60; `private` in our code always goes to the bottom REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4799 To: vpilo Cc: davidedmundson, dfaure, broulik, graesslin, mck182, #frameworks
