mdawson requested changes to this revision. mdawson added a comment. This revision now requires changes to proceed.
+1 This definitely looks like the correct fix. Can you please add some unit tests for this, to ensure it doesn't break in the future? I think just three extra tests, one for a desktop file in a config directory, one in a data directory, and one present elsewhere would be enough. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D5502 To: wbauer, #frameworks, mdawson Cc: mdawson, #frameworks
