graesslin added inline comments.

INLINE COMMENTS

> plasmawindowmodel.cpp:84
>  
> +    QObject::connect(window, &PlasmaWindow::pidChanged, q,
> +        [window, this] { this->dataChanged(window, PlasmaWindowModel::Pid); }

In the original report I critized that we connect to a pid changed signal. That 
doesn't make any sense as a pid cannot change.

I think this is the wrong solution to the problem.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5851

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, 
lukas

Reply via email to