kfunk added subscribers: arrowdodger, kfunk. kfunk requested changes to this revision. kfunk added a comment. This revision now requires changes to proceed.
I don't think we should do that. Compilation only breaks on MSVC2017, which is fairly new. And according to some test compilations by @arrowdodger, this seems to be the only location where we hit that compiler(?) bug when compiling all of KF5. Let's just work-around/rewrite this single code path. An other (less ideal) solution is to disable strict iterators for MSVC2017 only. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6073 To: bcooksley, kfunk Cc: kfunk, arrowdodger, #frameworks, #build_system