leinir added a comment.
On a similar note to handling comments, how does it now handle unknown/garbage tags? While it won't affect the cache code, it would potentially affect other things (ocs is not guaranteed to be perfectly formed, and it's one of the ways the framework's retained backwards compatibility). From what i can tell, this would assert when an unknown tag is encountered, right? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6067 To: apol, #frameworks Cc: leinir, dfaure