dfaure added a comment.
I don't use wayland, I use X11. I bet I'm not the only one. As long as that's the case, fixing bugs in the X11 implementation makes a lot of sense. Man it's demotivating to contribute to KDE. Users say all sorts of bad things about KDE, and then future-ex-maintainers reject your contribution. Great. INLINE COMMENTS > graesslin wrote in kglobalaccel_x11.cpp:278-287 > The shift handling code has shown regressions whenever it was touched. Also > on Wayland I needed several tries to get it right. I would prefer if it were > not touched any more. > > This is not as simple as it looks. There are besties out there like > Alt+Shift+Backtab as a global shortcut and a generic implementation breaks > quickly there. It is quite likely that this change would break > Alt+(Shift)+Tab in KWin. I did not change one inch of that logic, I just moved it to KKeyServer::xcbKeyPressEventToQt. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D6234 To: dfaure, graesslin Cc: #frameworks
