cfeck added inline comments.
INLINE COMMENTS
> kiconloader.cpp:863
> + % QLatin1Char('@')
> + % QString::number(scale)
> % QLatin1Char('_')
Please use some rounding here. Scaling factors such as 1.4 cannot be
represented exactly.
Either add some formatting specifiers, e.g. for three decimal places, or use
qRound(scale * 1000).
> kiconloader.h:247
>
> + // FIXME docs
> + QPixmap loadIcon(const QString &name, KIconLoader::Group group, qreal
> scale, int size = 0,
FIXME
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D6313
To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: cfeck, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart,
lukas
