elvisangelaccio added a comment.
Looks good to me now, just minor issues.
INLINE COMMENTS
> file.cpp:1407-1408
> +{
> + int status = messageBox(WarningContinueCancel, warningMessage(warnId),
> QStringLiteral("Warning!"),
> + QStringLiteral("Continue"),
> QStringLiteral("Cancel"));
> + return status != 2;
Missing i18n() here
> file.cpp:1409
> + QStringLiteral("Continue"),
> QStringLiteral("Cancel"));
> + return status != 2;
> +}
Use `ButtonCode::Cancel` rather than hardcoding 2
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6197
To: chinmoyr, elvisangelaccio, #frameworks, dfaure
Cc: eliasp, aacid
