apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  +1 for proper error messages!

INLINE COMMENTS

> engine.cpp:130
> +        emit signalError(i18n("Configuration file exists, but cannot be 
> opened: \"%1\"", configfile));
> +        qCritical() << "The knsrc file '" << configfile << "' was found but 
> could not be opened." << endl;
> +        return false;

are you sure the `endl` is necessary?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6340

To: leinir, #knewstuff, apol
Cc: apol, #frameworks, ZrenBot

Reply via email to