rjvbb marked 6 inline comments as done.
rjvbb added inline comments.
INLINE COMMENTS
> kfunk wrote in kateviewinternal.cpp:87
> Simplify: `else if (...) {`?
Why the question mark? Simplification should be perfectly fine here, no?
> kfunk wrote in kateviewinternal.cpp:121
> Initialize here
Instead of in the ctor, or in addition to?
The KateViewInternal class doesn't initialise any of its member variables this
way.
(http://en.cppreference.com/w/cpp/language/data_members ?)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D5037
To: rjvbb, #ktexteditor
Cc: kfunk, luebking, anthonyfieroni, dhaumann, kwrite-devel, #ktexteditor,
#frameworks, head7, cullmann, sars
