On lundi 5 juin 2017 14:42:47 CEST Marco Martin wrote: > Hi all, > The Kirigami component set always was targeted to be eventually released as > a framework, ideally tier 1. since a framework must depend at most from 2 > Qt releases before the current one, it couldn't be released there yet. Now > that Qt 5.9 is released
Given the LTS nature of Qt 5.6 I'd like to keep 5.6 as a base requirement for the other frameworks for a bit longer if possible, but this doesn't prevent kirigami from requiring Qt 5.7. This Qt version difference creates an issue for the CI though, as can be seen at https://build.kde.org/job/kirigami%20master%20stable-kf5-qt5/ > i would like to propose to move Kirigami in > frameworks, to be relased in the main release cycle, and stop standalone > releases from extragear. > > It strictly depends just from Qt stuff, so should be tier 1 (at runtime it > can use optional styles that use features from Plasma, tough not having > plasma installed doesn't touch its functionality in any part, if this ends > up being a problem, i can move that style into plasma-integration) I just cleaned up the toplevel CMakeLists.txt a bit, but I found an issue there: it checks for KF5Declarative_FOUND but doesn't do a find_package for that component, so this looks pretty useless. Since DESKTOP_ENABLED is on by default, what's the point of that if(KF5Declarative_FOUND AND THEME STREQUAL "System") ? I noticed that DESKTOP_ENABLED installs a file called styles/org.kde.desktop, which matches a runtime error I've seen for some time now, e.g. at QtCreator startup: QtCreator(12888)/default QQuickControlSettings1::QQuickControlSettings1: WARNING: Cannot find style "org.kde.desktop" - fallback: "/d/qt/5/kde/build/qtbase/qml/QtQuick/Controls/Styles/Desktop" I enabled BUILD_EXAMPLES and got a nice example "kirigami2gallery" built as a result, but why is it under the android subdirectory? (The good thing about this example is now I finally have an idea what kirigamy is about. The name doesn't really say much ;)) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
