chinmoyr updated this revision to Diff 17222. chinmoyr added a comment.
1. Separated enums, vars and functions 2. Removed hardcoding 3. Use the new signal privilegeOperationRequested 4. Removed public methods added in previous revision. Instead of them d_func is used (which should have been the case right from the start but I overlooked it somehow) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6832?vs=17021&id=17222 BRANCH temp REVISION DETAIL https://phabricator.kde.org/D6832 AFFECTED FILES src/core/job.cpp src/core/job_base.h src/core/job_p.h src/core/simplejob.cpp src/core/simplejob.h To: chinmoyr, dfaure, #frameworks Cc: #frameworks