kfunk added inline comments. INLINE COMMENTS
> cfeck wrote in kpasswordlineedit.cpp:30 > That's fishy. I just checked a single class (KColumnResizer), and it has just > "class KColumnResizerPrivate" (no namespace, no QObject), and still has a > Q_PRIVATE_SLOT in its KColumnResizer class. +1. Don't use nested private classes. Nested classes/structs inherit the symbols visibility. Also see: https://phabricator.kde.org/D6927 PS: In times of Qt5 & lambda-connects, you don't need Q_PRIVATE_SLOT anymore, anyway: Just remove the `Q_PRIVATE_SLOT` marker and ...: `connect(..., this, [this](...) { d->myPrivateSlot(...); });` REVISION DETAIL https://phabricator.kde.org/D7011 To: mlaurent, cfeck, dfaure, elvisangelaccio Cc: kfunk, kossebau, elvisangelaccio, #frameworks
