dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
The diff has no context in phabricator, which is a problem for this one (e.g.
for the "do we need this here?" questions). Can you upload the update using
`arc diff` for example?
INLINE COMMENTS
> file_unix.cpp:126
> + if (!execWithElevatedPrivilege(errno, DEL, _dest))
> + error(KIO::ERR_CANNOT_DELETE_ORIGINAL, dest);
> + }
Missing "return;" no?
> file_unix.cpp:176
> + if (!execWithElevatedPrivilege(errno, CHOWN, buff_src.st_uid,
> buff_src.st_gid)) {
> + error(KIO::ERR_CANNOT_CHOWN, dest);
> + }
missing return;
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6830
To: chinmoyr, dfaure, #frameworks
Cc: elvisangelaccio, #frameworks
