Present: me, chinmoy
Minutes in the attachment.
Cheers,
Elvis
2017-08-06 14:59:49 eang I'm finally here, shall we start the meeting?
2017-08-06 15:00:07 chinmoy[m] eang, i am here
2017-08-06 15:03:58 eang chinmoy: let's start!
2017-08-06 15:04:41 chinmoy[m] ok
2017-08-06 15:07:01 chinmoy[m] I spent this week figuring out the
suitable permissions when creating files and folders
2017-08-06 15:07:57 chinmoy[m] some of the operations were not working
due to incorrect permissions and ownership
2017-08-06 15:09:57 chinmoy[m] Then i did some experiments by adding a
new KIO job to serve as parent when jobs are executed in loop
2017-08-06 15:11:16 chinmoy[m] AFAICS only dolphin seems to require
this. There is a work around forFileUndoManager
2017-08-06 15:11:41 chinmoy[m] and i cant find any other use case
where this new job might be needed
2017-08-06 15:12:09 eang can you show me where is this dolphin code?
2017-08-06 15:12:40 chinmoy[m] views/renamedialog.cpp ::renameItem()
2017-08-06 15:14:13 eang so there is a KIO::moveAs() in a loop, basically
2017-08-06 15:14:24 chinmoy[m] yes
2017-08-06 15:15:25 eang this also causes
https://bugs.kde.org/show_bug.cgi?id=364615
2017-08-06 15:15:27 sKreamer KDE bug 364615 in dolphin (general)
"after mass rename, ctrl+z (undo) should revert ALL folders/files names"
[normal,] https://bugs.kde.org/show_bug.cgi?id=364615
2017-08-06 15:17:04 eang and also
https://bugs.kde.org/show_bug.cgi?id=381483
2017-08-06 15:17:04 sKreamer KDE bug 381483 in dolphin (general)
"Dolphin hangs on mass rename" [normal,]
https://bugs.kde.org/show_bug.cgi?id=381483
2017-08-06 15:18:00 eang so, renaming in dolphin is messy
2017-08-06 15:18:28 chinmoy[m] so my new job isn't necessary
2017-08-06 15:19:02 chinmoy[m] from the bugs it seems a new method is
required in copyjob
2017-08-06 15:19:52 eang we may need dfaure's input for this
2017-08-06 15:20:39 chinmoy[m] yes. as a temporary solution we can
disable the rename option when multiple files are selected
2017-08-06 15:23:28 eang there is a KIO::move() that takes a list of urls
2017-08-06 15:23:41 eang can you try to seee if we can use that?
2017-08-06 15:24:06 chinmoy[m] it takes multiple source urls and one
dest url
2017-08-06 15:24:31 eang ah, right
2017-08-06 15:28:38 eang ok, let's postpone the rename issue and move on
2017-08-06 15:29:15 chinmoy[m] on surface it seems straightforward and
easy to fix
2017-08-06 15:31:08 chinmoy[m] but then its dinner time and i might be
wrong
2017-08-06 15:32:09 chinmoy[m] apart from these issues, I fixed my
existing patches.
2017-08-06 15:32:29 eang is the permission issue sorted out?
2017-08-06 15:33:38 chinmoy[m] yes. I wasn't serializing the path of
file thats why the warning
2017-08-06 15:33:51 chinmoy[m] in place of path i was passing the
permission
2017-08-06 15:34:53 chinmoy[m] this typo costed me a whole day
2017-08-06 15:35:31 eang eheh, happens all the time :)
2017-08-06 15:36:20 eang what's the status of unit tests? are they ready?
2017-08-06 15:37:43 chinmoy[m] nope. can't get my head around them.
2017-08-06 15:38:15 chinmoy[m] not that I dont understand the qt test,
its just the part of code to test
2017-08-06 15:39:15 chinmoy[m] what will you suggest, testing every
job with the new flag or just run a random job and check the metadata returned
by slave?
2017-08-06 15:41:45 eang the former is a good integration test, but I'm
not sure how to handle the authentication dialog
2017-08-06 15:41:56 eang the latter is a sort of white test that could
be also good
2017-08-06 15:41:59 chinmoy[m] we dont need to
2017-08-06 15:42:11 chinmoy[m] handle the auth dialog
2017-08-06 15:42:49 chinmoy[m] checking for validity of the kauth
action is also fine
2017-08-06 15:43:43 --> pursuivant
(pursuivant@kde/bot/commit-notifications) has joined #kde-fm
2017-08-06 15:43:43 pursuivant baloo (master) v5.9.0-763-g16f12765 *
l10n daemon script: CMakeLists.txt
2017-08-06 15:43:44 pursuivant GIT_SILENT Upgrade Qt5 version
requirement to 5.7.0.
2017-08-06 15:43:44 pursuivant
https://commits.kde.org/baloo/16f1276572704aebd12df0393aad01a6978b38f2
2017-08-06 15:44:07 eang then yes, I'd at least test the most important
jobs (e.g. CopyJob)
2017-08-06 15:45:25 chinmoy[m] ok, this makes more sense
2017-08-06 15:47:09 chinmoy[m] it may need some rearranging in
execWithElevatePrivilege method as the code for unit test is after the signal
for warning dialog
2017-08-06 15:49:21 eang ok, anything else you wanted to discuss?
2017-08-06 15:49:48 chinmoy[m] no
2017-08-06 15:50:27 eang reminders from my side: update
https://community.kde.org/GSoC/2017/StatusReports/chinmoyrp
2017-08-06 15:50:39 eang and ping Thiago for the socket stuff
2017-08-06 15:52:49 chinmoy[m] yeah, didn't got time to update it in
all this mess. and I have pinged thiago twice on phab. now i am waiting for his
reply.
2017-08-06 15:53:40 eang ok, that's all then
2017-08-06 15:53:48 chinmoy[m] ok
2017-08-06 15:53:50 eang meeting over, thanks!
