apol added inline comments.

INLINE COMMENTS

> CMakeLists.txt:15
>  if(APPLE)
> -    target_link_libraries(testtrash "-framework DiskArbitration -framework 
> CoreFoundation")
> +    set(testtrash_APPLE_LIBS "-framework DiskArbitration -framework 
> CoreFoundation")
>  endif(APPLE)

Note that `target_link_libraries` can still be used with ecm_add_test.
I'd say it's better for readability to use the commands rather than passing 
cmake variables around.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7213

To: asturmlechner, #frameworks, kfunk
Cc: apol, kfunk

Reply via email to