dhaumann added a comment.
Looks already quite good. But I think one more iteration to especially fix the licensing would be nice. INLINE COMMENTS > foldingtest.pony:2 > +/* > + Copyright (C) 2016 Volker Krause <vkra...@kde.org> > + Is this file intentionally added? > highlight.pony:1 > +primitive Red fun apply(): U32 => 0xFFFF0000 > + Can you add a license as comment? MIT license is preferred. > pony.xml:11 > +]> > +<language author="Jonathan Poelen (jonathan.poe...@gmail.com)" > + name="Pony" section="Sources" Can you add license="MIT" as license? > pony.xml:283 > + </comments> > + <keywords casesensitive="1" /> > + </general> You may want to add # to the weakDeliminator list, to make cursor navigation like ctrl+left work correctly, since some keywords contain #. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7297 To: jpoelen, #framework_syntax_hightlighting Cc: dhaumann, #frameworks, cullmann, vkrause
