ltoscano added a comment.
I can't comment on the content of the patch, but about the commit message, in order to close a bug, use the syntax: BUG: nnnnnn while in order to add the commit as comment of a bug without closing it, use CCBUG: nnnnnn Both keyword should be in a separate line. Also, it's Qt, not QT. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7423 To: ngraham, dfaure, broulik, elvisangelaccio Cc: ltoscano, #frameworks