dhaumann added a subscriber: cfeck.
dhaumann added a comment.

  To me this looks good.
  
  It seems Q_PROPERTYs can be overridden (at least, this follows imho from "The 
presence of the FINAL attribute indicates that the property will not be 
overridden by a derived class" from http://doc.qt.io/qt-5/properties.html). 
That we should be fine.
  
  @cfeck A second review would be appreciated.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D7164

To: rkflx, #frameworks
Cc: cfeck, dhaumann

Reply via email to