ltoscano added a comment.
In https://phabricator.kde.org/D7668#142505, @ngraham wrote: > Oh good point, I forgot that this won't work if Baloo is disabled. I'll guard it behind an #ifdef, which appears to be the standard way to do this, looking through Dolphin's code. > > Since I'm proposing to change a default, the #ifdef will only avoid creating the bookmark on first launch for systems where Baloo is disabled at the distro-level. For users who opt to turn Baloo off themselves, I think it's safe to assume they're technically competent enough to understand the ramifications of that decision. But yes, it would be nice if there was a better error message. With Baloo disabled, I assume your Information panel also doesn't show Tags, right? I wouldn't assume this: what about the situation when Baloo is compiled in, but disabled by default? The point is that it's not always: - Baloo compiled out -> no nned for the bookmarks - Baloo compiled in -> enabled by default, the user may have turned it off because (for example) the distribution may have compiled it but disabled by default. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7668 To: ngraham, #frameworks, #dolphin, dfaure, davidedmundson, ltoscano, broulik, elvisangelaccio Cc: elvisangelaccio, cfeck, navarromorales, nicolasfella, firef, andrebarros, emmanuelp
