mlaurent added inline comments. INLINE COMMENTS
> kfileplacesmodeltest.cpp:83 > > + bool isFileIndexingEnabled; > QMap<QString, QDBusInterface *> m_interfacesMap; m_isFileIndexingEnabled > kfileplacesmodeltest.cpp:89 > { > return > QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + > "/user-places.xbel"; > } QStringLiteral("/user...") > kfileplacesitem.cpp:167 > > + if (protocol == (QLatin1String("groupstate"))) { > + return GroupStateType; Remove (...) around QLatin1String > kfileplacesitem_p.h:49 > RecentlySavedType, > + SearchForType, > DevicesType, is it a good idea to change order in enum ? I hope that nobody cast it as "int" :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8367 To: franckarrecot, renatoo Cc: mlaurent, #frameworks