elvisangelaccio added inline comments.
INLINE COMMENTS
> kio_smb.cpp:67
> SMBSlave::SMBSlave(const QByteArray& pool, const QByteArray& app)
> - : SlaveBase( "smb", pool, app ), m_openFd(-1)
> + : SlaveBase( "smb", pool, app ), m_openFd(-1),
> + m_enableEEXISTWorkaround(checkEnableEEXISTWorkaround())
While at it, I'd move `m_openFd` on its own line
> kio_smb_browse.cpp:521
>
> +bool SMBSlave::workaroundEEXIST(const int errNum) const
> +{
Maybe call it `needsWorkaroundEEXIST()`?
Current name seems to imply the method //is// the workaround, while it just
tells us whether we need the workaround.
> kio_smb_browse.cpp:523
> +{
> + return errNum == EEXIST && m_enableEEXISTWorkaround;
> +}
4 spaces here
REVISION DETAIL
https://phabricator.kde.org/D8387
To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks
Cc: graesslin, z3ntu
