subdiff added a comment.
In https://phabricator.kde.org/D8056#159636, @fabianr wrote: > Not really on topic, but could you change the label for the "Advanced options" to something more meaningful, eg "Terminal options" ? The HIG recommends not to use the label "Advanced options", but " Use a descriptive label so that it reflects the functionality. " Can we not just remove the drop down menu and always show the checkbox for terminal? @simgunz Please do the change to this though in a separate patch. And regarding your patch here please give @dfaure a few days to review it as well. Also @abetts should give his ok from VDG. I personally like the change. +1 REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks