smithjd marked 14 inline comments as done. smithjd added inline comments. INLINE COMMENTS
> dfaure wrote in kio_tags.cpp:64 > - merge with previous line > > - can path() really contain '?' ? I thought that wasn't possible (? delimits > the query). Yes, the url is non-hierarchical scheme, so everything is in the path. > dfaure wrote in kio_tags.cpp:292 > can this fail? No. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure Cc: dfaure, nicolasfella, ngraham