simgunz marked an inline comment as done.
simgunz added a comment.

  > @simgunz If you have no further changes planned for this Diff and 
https://phabricator.kde.org/D8670, I could land both on your behalf. Contact 
information of non-developers are private by default on identity.kde.org, but I 
found some in https://github.com/simgunz/redshift-plasmoid. Are those okay to 
use for the authorship (name + email)?
  
  I don't need to add anything so you can land both. The contact information 
you have found are fine. Is it there a way to make my contact info in kde 
identity public? I couldn't find an option for it.
  
  > Stumbled upon this too some time ago, amazingly you used the very same 
workaround I applied back then. Looking at 
https://en.wikipedia.org/wiki/Esc_key the similar looking glyph seems 
intentional, so I don't see a chance to convince Phab upstream to change this. 
Just embrace and use it, maybe we all get accustomed after a while :) At least 
we get tooltips for all those symbols: [⎋] + [⌘] + [⌥]
  
  Wow. Never saw that glyph before. One never finish learning.
  
  > As for the [↓] and completion popup issues, the root cause seems to be that 
we have one input line but two overlapping "lists", which is really weird 
conceptually and gets complex quite fast as you noticed. A (quick to talk 
about, slow to implement) idea would be to get rid of the completion popup even 
for advanced users and merge those results (recent inputs, but also some other 
search results like `kmimetypefinder` which are not even in a category!?) into 
the list view as a new section.
  > 
  > This definitely needs more thinking, no need to rush…
  
  Yes, doesn't seems trivial. We can talk about it.
  
  One last note on this modification. Given that the previous default was to 
use `PopupCompletion`, it means that most of the users out there have this 
setting configured. And if they are like me, most of them don't even know they 
can change this behavior. If there will be any type of announcement or 
changelog regarding this change, it may be useful to explicitly suggest to 
change to completion `None` in order to fully enjoy the new feature without the 
popup covering the tree.

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

Reply via email to