dfaure added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kdatecombobox.cpp:350-351
> Why not
> 
>   d->enterDate(date());
> 
> ?

Good point, `enterDate()` enables the warning-on-invalid when this option is 
set, and I suppose we want that on Key_Return as well.
However I still need to emit `dateChanged()`, since `setDate()` doesn't do that 
in this case (it thinks the date hasn't changed, given that we're calling 
`setDate(date())`).

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8908

To: dfaure, cfeck, dvratil
Cc: anthonyfieroni, #frameworks, #kde_pim

Reply via email to