apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> kfunk wrote in kjobwidgets.cpp:67
> `WId` is a `quintptr`: `src/gui/kernel/qwindowdefs.h:99:typedef 
> QT_PREPEND_NAMESPACE(quintptr) WId;`
> 
> Besides: `QVariant::fromValue(window->winId())` should work just fine, or?

Note I didn't change any code, I just moved it around.

Removing the cast still seems to work, so I'll do that.

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D8923

To: apol, #frameworks
Cc: kfunk

Reply via email to